Remove the FileDef preview stage's floating provenance tag - #5814
Open
lukemelia wants to merge 1 commit into
Open
Remove the FileDef preview stage's floating provenance tag#5814lukemelia wants to merge 1 commit into
lukemelia wants to merge 1 commit into
Conversation
lukemelia
changed the title
lukemelia
force-pushed
the
cs-12551-fitted-filedef-previews-translucent-provenance-tag-native
branch
from
August 18, 2026 19:21
de43558 to
5e0da40
Compare
Contributor
The stage floated a provenance tag (previewSource uppercased — NATIVE,
EXTRACTED, GENERATED) over every real preview, absolutely positioned at
the stage's top-left with a translucent background. That corner is
where several families draw their own content: a prose preview's title
(HTML summary, Markdown snippet) and an archive tree's first row all
rendered with the tag overprinting their first words into an
unreadable jumble.
The overlay is removed in every format. Provenance already has a
legible home: the isolated shell's metadata chrome describes the
render source in prose ("The browser displays…", "Structured…"), and
the fitted shell's metadata strip identifies the file. A test pins
that the stage floats no tag over the family's render in any format.
Fixes CS-12551.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lukemelia
force-pushed
the
cs-12551-fitted-filedef-previews-translucent-provenance-tag-native
branch
from
August 18, 2026 20:58
5e0da40 to
9d8a0a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
FilePreviewStagefloated a provenance tag over every real preview — the profile'spreviewSourceuppercased ("NATIVE" for the HTML/Markdown families, "EXTRACTED" for archives) — absolutely positioned at the stage's top-left with a translucent background. That corner is exactly where several families draw their own content: the HTML summary and Markdown snippet begin their document title there, and the zip family's archive tree starts its first row there. In all of those, the tag overprinted the content's first words into an unreadable jumble (observed on staging in the fixture gallery for HTML and Markdown fitted tiles, and in the zip embedded view).The overlay is removed in every format. Provenance keeps a legible home where layout actually reserves space for it:
Test plan
packages/host/tests/integration/components/file-def-format-templates-test.gts: a preview-bearing FileDef mounts its family renderer in embedded, isolated, and fitted with no floating tag over the stage in any of them. Full module: 16 tests, 57 assertions, passing locally against a full dev stack.Fixes CS-12551.
🤖 Generated with Claude Code